[fix][test] AdvertisedListenersTest.setup - #17869
Merged
codelipenghui merged 2 commits intoOct 17, 2022
Merged
Conversation
congbobo184
added
type/flaky-tests
doc-not-needed
congbobo184
requested review from
codelipenghui,
eolivelli,
gaoran10 and
liangyepianzhou
September 28, 2022 09:39
congbobo184
changed the title
codelipenghui
approved these changes
Oct 13, 2022
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #17869 +/- ##
=========================================
Coverage ? 45.76%
Complexity ? 17549
=========================================
Files ? 1574
Lines ? 128224
Branches ? 14100
=========================================
Hits ? 58678
Misses ? 63492
Partials ? 6054
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
codelipenghui
changed the title
shibd
pushed a commit
to shibd/pulsar
that referenced
this pull request
Oct 22, 2023
shibd
pushed a commit
to shibd/pulsar
that referenced
this pull request
Oct 23, 2023
shibd
pushed a commit
to shibd/pulsar
that referenced
this pull request
Oct 23, 2023
shibd
pushed a commit
to shibd/pulsar
that referenced
this pull request
Oct 24, 2023
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #16544
Motivation
now in tests, we getFreePort not occupied, just written in configuration, so it may be created repeatedly. If the socket port is repeatedly, the test will become flaky.
Modifications
when we getFreePort, the port will be occupied and then if you use finished can release this port.
Documentation
doc-not-neededMatching PR in the forked repository
PR in forked repository: